FRONT-1978: Update @streamr/config to the "typed" version (v5.5.0) + clean up
#1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isolating this change may cause some mess. Will fix it shortly.
mondoreale
commented
Feb 7, 2025
| @@ -17,7 +17,7 @@ export default function getClientConfig( | |||
| if (chainConfig.entryPoints && chainConfig.entryPoints.length > 0) { | |||
| config.network = { | |||
| controlLayer: { | |||
| entryPoints: chainConfig.entryPoints, | |||
| entryPoints: [...chainConfig.entryPoints], | |||
There was a problem hiding this comment.
controlLayer.entryPoints is a mutable collection while chainConfig.entryPoints is a read-only collection. ts rightfully complains.
| @@ -97,8 +97,6 @@ export function getContractAddress( | |||
| return contracts.SponsorshipStakeWeightedAllocationPolicy | |||
| case 'sponsorshipVoteKickPolicy': | |||
| return contracts.SponsorshipVoteKickPolicy | |||
| case 'sponsorshipPaymentToken': | |||
| return contracts.SponsorshipPaymentToken | |||
There was a problem hiding this comment.
Interesting! sponsorshipPaymentToken is properly resolved by this switch earlier. This here is redundant, plus, sponsorshipPaymentToken doesn't exist on contracts anyway.
Issue detected by the typed config. Pretty cool.
tumppi
approved these changes
Feb 11, 2025
mondoreale
deleted the
front-1978-update-streamrconfig-to-the-typed-version-v550-clean-up
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I make sure we're using the latest
@streamr/configpackage (exposes proper types for the config and chains). I also clean things up a bit. There's room for more but I don't wanna pollute it just yet (#1965 could be addressed first).Future improvement material
ChainKey(polygon,dev0, …) which could be use to narrow hub's types even further.